Implement cloud flow for plural up
#530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljguarino
requested review from
zreigz,
floreks and
maciaszczykm
as code owners
michaeljguarino
force-pushed
the
cloud-up
branch
2 times, most recently
from
da7a773 to
141cc2d
Compare
This adds a `--cloud` flag to plural up to create a console-less management cluster and register it w/ a hosted console. There are definitely some other ux things we should smooth here, but for now it's good.
michaeljguarino
force-pushed
the
cloud-up
branch
from
141cc2d to
8b44bd4
Compare
zreigz
approved these changes
Aug 26, 2024
|
@michaeljguarino I have finished the |
|
@zreigz looks like there might be some merge conflicts if we could resolve those otherwise lgtm |
michaeljguarino
added a commit
that referenced
this pull request
Aug 28, 2024
* Implement cloud flow for `plural up` This adds a `--cloud` flag to plural up to create a console-less management cluster and register it w/ a hosted console. There are definitely some other ux things we should smooth here, but for now it's good. * fix go.mod * fix pluralctl setup * fix some minor bugs * Use temp dir to clone bootstrap repo in * improve cloud flag * fix after rebase --------- Co-authored-by: Lukasz Zajaczkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--cloudflag to plural up to create a console-less management cluster and register it w/ a hosted console. There are definitely some other ux things we should smooth here, but for now it's good.Test Plan
local testing
Checklist